Filter Statistics: 0.9.9.29 hängt ab

[Bob Loeffler]

Great! Thanks Dieter.

I think it will be slower on very large files only. I tested it with a 39MB filter.log file and the new version took 12 seconds to display the graph, but with the old version, it took less than 2 seconds. Oh well. It is safer now.

Bob

[Dieter]

I tested it with a 39MB filter.log file

39 MB??
I have 3.91 MB, and I never waited 12 seconds.

Regards,
Dieter

[Bob Loeffler]

I also tested a 19MB file and it took 6 or 7 seconds to process. A 206k file took only 1 second. Hopefully everyone will be happy with it.

Regards,

Bob

[michel]

Hi Bob!

You can still improve the performance. If you use fgets() (like you did before) to read a block into a buffer. Then check, if the last character is '\n'. If not, read another block until you read the whole line.

This could look like this (not correct C++ code):

Code: Alles auswählen

void readline(FILE *f, std::string &result)
{
  result = "";
  char block[512];
  while (fgets(block, 512, f))
  {
    if (block[strlen(block) - 1] == '\n')
      return;
    result.append(block);
  }
}

I haven't tested this yet, but it should speed up your code.

Sincerely,
Michel

[Bob Loeffler]

Hi Michel!

Thanks. I will try this and see if it helps.

Regards,

Bob

[Clinamen]

Hi Bob,

I downloaded the new filterstat and everything works fine now.
Thanks a lot for this great plugin.
Christian.

[Bob Loeffler]

You are welcome, Christian. I will try to make it faster with Michel's code, but I have not found any free time to do it yet.

Regards,

Bob

[Bob Loeffler]

Hi all!!!!!

I have been away for a long time, but I am back now!

I found another bug that caused Spamihilator to create a .dmp file, so the fix is in the latest Filter Statistics plugin (v1.1.4) that I will post soon.

Regards,

Bob

[anbuva]

Hallo Bob Loeffler!

we have missed you so and are pleased to hear from you again.

Gruß
anbuva

[Bob Loeffler]

Hi anbuva!

I missed you and everyone else also! Hopefully I'll be around the forum more often now. I don't have that evil girlfriend who took me away a couple years ago.

Here is a link to the new Filter Statistics v1.1.4 installer until Michel can put it in the plug-ins add-ons page:

http://www.peaktopeak.com/spamihilator/ ... _1_1_4.exe

Regards,

Bob

[anbuva]

Hallo Bob Loeffler!

Welcome back and feel well.
The new filter works without problems. Thanks.

Regards
anbuva

[Bob Loeffler]

Thanks anbuva!

Bob

[michel]

Hello Bob!

Nice to have you back! I will upload your new filter today in the evening or tomorrow.

Regards,
Michel

[Andreas_Z]

Hello Bob Loeffler!

welcome back and greetings from Germany

Andreas_Z

[Bob Loeffler]

Hi Michel and AndreasZ! I am glad that you are both still here!!!!

Thanks Michel!

Regards,

Bob